Draft
Conversation
FloEdelmann
added
new-fixture
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ chauvet-dj / slimpar-t12-ils: d-light / attributes-correctness
✔️ chauvet-dj / slimpar-t12-ils: dmxcontrol3 / channel-numbers
✔️ chauvet-dj / slimpar-t12-ils: dragonframe / json-schema-conformity
✔️ chauvet-dj / slimpar-t12-ils: millumin / json-schema-conformity
✔️ chauvet-dj / slimpar-t12-ils: qlcplus_4.12.2 / fixture-tool-validation
✔️ chauvet-dj / slimpar-t12-ils: qlcplus_4.12.2 / xsd-schema-conformity
|
kengruven
reviewed
Feb 3, 2025
| { | ||
| "$schema": "https://raw.githubusercontent.com/OpenLightingProject/open-fixture-library/master/schemas/fixture.json", | ||
| "name": "SlimPAR T12 ILS", | ||
| "categories": ["Color Changer", "Dimmer", "Effect", "Strobe"], |
Contributor
There was a problem hiding this comment.
Suggested change
| "categories": ["Color Changer", "Dimmer", "Effect", "Strobe"], | |
| "categories": ["Color Changer"], |
| }, | ||
| { | ||
| "dmxRange": [16, 255], | ||
| "type": "ColorPreset" |
Contributor
There was a problem hiding this comment.
Suggested change
| "type": "ColorPreset" | |
| "type": "ColorPreset", | |
| "helpWanted": "What colors at what values?" |
Comment on lines
+210
to
+215
| "Strobe", | ||
| "Program", | ||
| "Dimmer", | ||
| "Dimmer speed", | ||
| "Sound Sensitivity", | ||
| "Program Speed" |
Contributor
There was a problem hiding this comment.
Suggested change
| "Strobe", | |
| "Program", | |
| "Dimmer", | |
| "Dimmer speed", | |
| "Sound Sensitivity", | |
| "Program Speed" | |
| "Strobe / Program speed / Sound sensitivity", | |
| "Program", | |
| "Dimmer", | |
| "Dimmer speed" |
Comment on lines
+170
to
+171
| "soundSensitivity": "off", | ||
| "comment": "when Ch. 6 is 32<=>223" |
Contributor
There was a problem hiding this comment.
Suggested change
| "soundSensitivity": "off", | |
| "comment": "when Ch. 6 is 32<=>223" | |
| "soundSensitivity": "off" |
Comment on lines
+177
to
+178
| "soundSensitivityEnd": "high", | ||
| "comment": "when Ch. 6 is 224<=>255" |
Contributor
There was a problem hiding this comment.
Suggested change
| "soundSensitivityEnd": "high", | |
| "comment": "when Ch. 6 is 224<=>255" | |
| "soundSensitivityEnd": "high" |
| { | ||
| "dmxRange": [128, 159], | ||
| "type": "Effect", | ||
| "effectName": "Automatic fade" |
Contributor
There was a problem hiding this comment.
Suggested change
| "effectName": "Automatic fade" | |
| "effectName": "Automatic fade", | |
| "switchChannels": { | |
| "Strobe / Program speed / Sound sensitivity": "Program speed" | |
| } |
| { | ||
| "dmxRange": [160, 191], | ||
| "type": "Effect", | ||
| "effectName": "Automatic 3-color snap" |
Contributor
There was a problem hiding this comment.
Suggested change
| "effectName": "Automatic 3-color snap" | |
| "effectName": "Automatic 3-color snap", | |
| "switchChannels": { | |
| "Strobe / Program speed / Sound sensitivity": "Program speed" | |
| } |
| { | ||
| "dmxRange": [192, 223], | ||
| "type": "Effect", | ||
| "effectName": "Automatic 7-color snap" |
Contributor
There was a problem hiding this comment.
Suggested change
| "effectName": "Automatic 7-color snap" | |
| "effectName": "Automatic 7-color snap", | |
| "switchChannels": { | |
| "Strobe / Program speed / Sound sensitivity": "Program speed" | |
| } |
| "dmxRange": [224, 255], | ||
| "type": "Effect", | ||
| "effectName": "Sound-active 7-color snap", | ||
| "soundControlled": true |
Contributor
There was a problem hiding this comment.
Suggested change
| "soundControlled": true | |
| "soundControlled": true, | |
| "switchChannels": { | |
| "Strobe / Program speed / Sound sensitivity": "Sound sensitivity" | |
| } |
Comment on lines
+136
to
+160
| { | ||
| "dmxRange": [0, 51], | ||
| "type": "Generic", | ||
| "comment": "Dimmer speed set from display menu" | ||
| }, | ||
| { | ||
| "dmxRange": [52, 101], | ||
| "type": "Speed", | ||
| "speed": "stop" | ||
| }, | ||
| { | ||
| "dmxRange": [102, 152], | ||
| "type": "Speed", | ||
| "speed": "fast" | ||
| }, | ||
| { | ||
| "dmxRange": [153, 203], | ||
| "type": "Speed", | ||
| "speed": "50%" | ||
| }, | ||
| { | ||
| "dmxRange": [204, 255], | ||
| "type": "Speed", | ||
| "speed": "slow" | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| { | |
| "dmxRange": [0, 51], | |
| "type": "Generic", | |
| "comment": "Dimmer speed set from display menu" | |
| }, | |
| { | |
| "dmxRange": [52, 101], | |
| "type": "Speed", | |
| "speed": "stop" | |
| }, | |
| { | |
| "dmxRange": [102, 152], | |
| "type": "Speed", | |
| "speed": "fast" | |
| }, | |
| { | |
| "dmxRange": [153, 203], | |
| "type": "Speed", | |
| "speed": "50%" | |
| }, | |
| { | |
| "dmxRange": [204, 255], | |
| "type": "Speed", | |
| "speed": "slow" | |
| } | |
| { | |
| "dmxRange": [0, 51], | |
| "type": "Maintenance", | |
| "comment": "Dimmer speed set from display menu" | |
| }, | |
| { | |
| "dmxRange": [52, 101], | |
| "type": "Maintenance", | |
| "speed": "Dimmer speed mode off" | |
| }, | |
| { | |
| "dmxRange": [102, 152], | |
| "type": "Maintenance", | |
| "speed": "Dimmer speed mode 1 (fast)" | |
| }, | |
| { | |
| "dmxRange": [153, 203], | |
| "type": "Maintenance", | |
| "speed": "Dimmer speed mode 2 (medium)" | |
| }, | |
| { | |
| "dmxRange": [204, 255], | |
| "type": "Maintenance", | |
| "speed": "Dimmer speed mode 3 (slow)" | |
| } |
In other fixtures, OFL uses Maintenance for dimmer speed. I can't find a definition of a generic "Speed" parameter but I think it's generally intended for effects. In particular, "off" here probably means "instantaneous", which is very different from "stop".
There was a problem hiding this comment.
Nice to learn that, thanks for correction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chauvet-dj/slimpar-t12-ilsFixture warnings / errors
Thank you @Mouflon23!